Skip to content

chore: move ruff configuration to dedicated ruff.toml file #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 21, 2025
Merged

chore: move ruff configuration to dedicated ruff.toml file #237

merged 3 commits into from
Jan 21, 2025

Conversation

@devin-ai-integration
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Jan 21, 2025 •
edited
Loading

Description

This PR moves the Ruff configuration from pyproject.toml to a dedicated ruff.toml file at the root of the repository. This change follows the common practice of keeping Ruff configuration in its own file for better visibility and maintainability.

Closes #238

Changes

  • Created new ruff.toml with existing Ruff configuration
  • Removed Ruff configuration from pyproject.toml
  • Updated CONTRIBUTING.md to reference the new configuration location
  • Verified that Ruff commands continue to work as expected

Testing

  • ✅ Verified that ruff check . runs successfully
  • ✅ Verified that ruff format --check . runs successfully
  • ✅ All existing Ruff functionality remains intact

Link to Devin run: https://app.devin.ai/sessions/89cf98f8fbc74663aa2a8690acf34215

@devin-ai-integration
Copy link
Contributor Author

devin-ai-integration bot commented Jan 21, 2025

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@devin-ai-integration devin-ai-integration bot changed the title refactor: move ruff configuration to dedicated ruff.toml file chore: move ruff configuration to dedicated ruff.toml file Jan 21, 2025
aaronsteers
aaronsteers approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@aaronsteers aaronsteers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. 👍

@aaronsteers aaronsteers merged commit 1494458 into main Jan 21, 2025
20 of 21 checks passed
@aaronsteers aaronsteers deleted the devin/1737497851-move-ruff-config branch January 21, 2025 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aaronsteers aaronsteers aaronsteers approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Move projects' ruff rules out of pyproject.toml files and into their own ruff.toml files

2 participants

@aaronsteers